public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: PPC: Add devname:kvm aliases for modules
Date: Tue, 10 Dec 2013 10:45:38 +0400	[thread overview]
Message-ID: <52A6B892.5040304@msgid.tls.msk.ru> (raw)
In-Reply-To: <1386601315-46622-1-git-send-email-agraf@suse.de>

09.12.2013 19:01, Alexander Graf wrote:
[]
> +++ b/arch/powerpc/kvm/44x.c
> @@ -231,3 +231,6 @@ static void __exit kvmppc_44x_exit(void)
>  
>  module_init(kvmppc_44x_init);
>  module_exit(kvmppc_44x_exit);
> +#include <linux/miscdevice.h>
> +MODULE_ALIAS_MISCDEV(KVM_MINOR);
> +MODULE_ALIAS("devname:kvm");

Usual thing is to add #includes into the beginning of a source file,
not at the end of it, here and in all other similar places.

Thanks,

/mjt

  reply	other threads:[~2013-12-10  6:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09 15:01 [PATCH] KVM: PPC: Add devname:kvm aliases for modules Alexander Graf
2013-12-10  6:45 ` Michael Tokarev [this message]
2014-01-08 15:30 ` mihai.caraman
  -- strict thread matches above, loose matches on Subject: below --
2014-01-08 15:41 mihai.caraman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A6B892.5040304@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox