From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Subject: Re: [PATCH] KVM: PPC: Add devname:kvm aliases for modules Date: Tue, 10 Dec 2013 10:45:38 +0400 Message-ID: <52A6B892.5040304@msgid.tls.msk.ru> References: <1386601315-46622-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, KVM list To: Alexander Graf Return-path: In-Reply-To: <1386601315-46622-1-git-send-email-agraf@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org 09.12.2013 19:01, Alexander Graf wrote: [] > +++ b/arch/powerpc/kvm/44x.c > @@ -231,3 +231,6 @@ static void __exit kvmppc_44x_exit(void) > > module_init(kvmppc_44x_init); > module_exit(kvmppc_44x_exit); > +#include > +MODULE_ALIAS_MISCDEV(KVM_MINOR); > +MODULE_ALIAS("devname:kvm"); Usual thing is to add #includes into the beginning of a source file, not at the end of it, here and in all other similar places. Thanks, /mjt