From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC PATCH v3 1/2] add support for Hyper-V reference time counter
Date: Thu, 12 Dec 2013 10:33:15 +0100
Message-ID: <52A982DB.6010609@redhat.com>
References: <1386502419-26614-1-git-send-email-vrozenfe@redhat.com> <1386502419-26614-2-git-send-email-vrozenfe@redhat.com> <20131211185305.GA28207@amt.cnet> <20131211185904.GB28207@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Vadim Rozenfeld <vrozenfe@redhat.com>, kvm@vger.kernel.org,
	pl@dlhnet.de
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:45734 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751506Ab3LLJdX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 12 Dec 2013 04:33:23 -0500
In-Reply-To: <20131211185904.GB28207@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 11/12/2013 19:59, Marcelo Tosatti ha scritto:
> > Where does the docs say that HV_X64_MSR_HYPERCALL is the where the clock
> > starts counting?
> > 
> > No need to store kvmclock_offset in hv_ref_count? (moreover
> > the name is weird, better name would be "hv_ref_start_time".
> 
> Just add kvmclock_offset when reading the values (otherwise you have a
> "stale copy" of kvmclock_offset in hv_ref_count).

As mentioned in my review, v4 will probably read kvmclock to provide the
reference time counter.  So all the complexity of kvmclock_offset will
be hidden behind a function.

Paolo