public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, kvm@vger.kernel.org
Subject: Re: kvm-kmod and kernels 3.11.*
Date: Fri, 13 Dec 2013 17:24:42 +0100	[thread overview]
Message-ID: <52AB34CA.3020102@redhat.com> (raw)
In-Reply-To: <20131213161859.GB14762@ERROL.INI.CMU.EDU>

Il 13/12/2013 17:19, Gabriel L. Somlo ha scritto:
> So I tried to mimic the existing "sed" functionality of the "sync"
> script, and was was left deciding between excising the call to         smp_mb__after_srcu_read_unlock() from line 6009 of x86.c (since it's
> defined as a no-op in the header), or sed-ing in the declaration from
> the kvm srcu.h via the sync script. I think the latter is slightly less
> cheesy, but I'm really curious what you think would have been the
> "canonical" way to do this :)

You can also do this:

diff --git a/external-module-compat-comm.h b/external-module-compat-comm.h
index 34fb320..5fa075e 100644
--- a/external-module-compat-comm.h
+++ b/external-module-compat-comm.h
@@ -1408,3 +1408,7 @@ static inline void guest_exit(void)
 }
 #endif /* !CONFIG_CONTEXT_TRACKING */
 #endif /* < 3.10 */
+
+#if LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0)
+#define smp_mb__after_srcu_read_unlock() smp_mb()
+#endif

Paolo

  reply	other threads:[~2013-12-13 16:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12 21:27 kvm-kmod and kernels 3.11.* Gabriel L. Somlo
2013-12-12 21:59 ` Paolo Bonzini
2013-12-13 15:04   ` Jan Kiszka
2013-12-13 15:12     ` Paolo Bonzini
2013-12-13 15:36       ` Jan Kiszka
2013-12-13 16:19         ` Gabriel L. Somlo
2013-12-13 16:24           ` Paolo Bonzini [this message]
2013-12-13 16:26           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AB34CA.3020102@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gsomlo@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox