From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC][PATCH] KVM: nVMX: Leave VMX mode on apparent CPU reset Date: Tue, 17 Dec 2013 15:43:34 +0100 Message-ID: <52B06316.1010906@redhat.com> References: <52AEC8B2.7010602@siemens.com> <52B050C6.5090407@redhat.com> <52B0626F.2090905@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27795 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320Ab3LQOnr (ORCPT ); Tue, 17 Dec 2013 09:43:47 -0500 In-Reply-To: <52B0626F.2090905@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 17/12/2013 15:40, Jan Kiszka ha scritto: >> > The final vmx_vcpu_reset is the only really ugly part, but it is >> > _really_ ugly... Can you modify QEMU to restore MSRs first, and reduce >> > vmx_reset_nested to just >> > >> > if (is_guest_mode(vcpu)) >> > nested_vmx_vmexit(vcpu); >> > >> > free_nested(vmx); >> > >> > ? > Well, I could make setting of MSR_IA32_FEATURE_CONTROL to 0 an official > "clear VMX" interface. Then QEMU would have to issue this MSR set > request before doing any other CPU state manipulation. Is that what you > have in mind? Yes, that was the idea. Paolo