From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCHv3] kvm/irqchip: Speed up KVM_SET_GSI_ROUTING
Date: Fri, 17 Jan 2014 16:03:19 +0100
Message-ID: <52D94637.8090602@de.ibm.com>
References: <52D7C186.1070700@redhat.com> <1389876260-46636-1-git-send-email-borntraeger@de.ibm.com> <20140116185520.GC29522@redhat.com> <52D83BF2.6030705@de.ibm.com> <20140116202213.GF29522@redhat.com> <52D9383F.7040206@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Gleb Natapov <gleb@minantech.com>, KVM <kvm@vger.kernel.org>,
	linux-s390 <linux-s390@vger.kernel.org>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>, agraf@suse.de
To: Paolo Bonzini <pbonzini@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:40831 "EHLO
	e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752964AbaAQPDf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 17 Jan 2014 10:03:35 -0500
Received: from /spool/local
	by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <kvm@vger.kernel.org> from <borntraeger@de.ibm.com>;
	Fri, 17 Jan 2014 15:03:34 -0000
In-Reply-To: <52D9383F.7040206@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 17/01/14 15:03, Paolo Bonzini wrote:
> Il 16/01/2014 21:22, Michael S. Tsirkin ha scritto:
>>> [PATCHv3] kvm/irqchip: Speed up KVM_SET_GSI_ROUTING
>>>
>>> When starting lots of dataplane devices the bootup takes very long
>>> on my s390 system(prototype irqfd code). With larger setups we are even
>>> able to trigger some timeouts in some components.
>>> Turns out that the KVM_SET_GSI_ROUTING ioctl takes very
>>> long (strace claims up to 0.1 sec) when having multiple CPUs.
>>> This is caused by the  synchronize_rcu and the HZ=100 of s390.
>>>
>>> Lets use the expedited variant to speed things up as suggested by
>>> Michael S. Tsirkin
>>>
>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>>  virt/kvm/irqchip.c |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c
>>> index 20dc9e4..dbcfde7 100644
>>> --- a/virt/kvm/irqchip.c
>>> +++ b/virt/kvm/irqchip.c
>>> @@ -226,7 +226,7 @@ int kvm_set_irq_routing(struct kvm *kvm,
>>>  	kvm_irq_routing_update(kvm, new);
>>>  	mutex_unlock(&kvm->irq_lock);
>>>  
>>> -	synchronize_rcu();
>>> +	synchronize_rcu_expedited();
>>>  
>>>  	new = old;
>>>  	r = 0;
>> --
>> To unsubscribe from this list: send the line "unsubscribe kvm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> Well... I love to contradict myself, so: no way this can be accepted
> this close to the end of the merge window.  :(
> 
> synchronize_rcu_expedited() forces a context switch on all CPUs, even
> those that are not running KVM.  Thus, this patch might help a guest DoS
> its host by changing the IRQ routing tables in a loop.
> 
> So this will have to wait for 3.15.  We have ~2 months to do performance
> measurements on the v2 patch.  Sorry.

Any chance that you or Michael can give some performance feedback on v2? All
my lab systems are s390 and not x86...