From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 04/13] VMX: Fix return label in fault-triggering handlers Date: Wed, 22 Jan 2014 18:21:28 +0100 Message-ID: <52DFFE18.2060209@redhat.com> References: <59793077f3173bfa9f211c38617d288611f3a11f.1388858359.git.jan.kiszka@web.de> <52DFDD00.5000908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Jan Kiszka , Gleb Natapov , Marcelo Tosatti Return-path: Received: from mail-qc0-f180.google.com ([209.85.216.180]:37147 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752510AbaAVRVe (ORCPT ); Wed, 22 Jan 2014 12:21:34 -0500 Received: by mail-qc0-f180.google.com with SMTP id i17so908154qcy.11 for ; Wed, 22 Jan 2014 09:21:34 -0800 (PST) In-Reply-To: <52DFDD00.5000908@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 22/01/2014 16:00, Paolo Bonzini ha scritto: > Il 04/01/2014 18:59, Jan Kiszka ha scritto: >> From: Jan Kiszka >> >> Some compiler versions (seen with gcc 4.8.1) move the resume label after >> the return statement which, of course, causes sever problems. > > Can you include the assembly output? Do you mean after the "ret" > instruction? Reproduced now, I think it's a compiler bug... with -O2 it's even weird, &&resume points to the *first* instruction in the function. I'll report it to GCC. Paolo