From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Christoffer Dall <christoffer.dall@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
kvm-ppc <kvm-ppc@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [RFC PATCH] KVM: Specify byte order for KVM_EXIT_MMIO
Date: Fri, 24 Jan 2014 14:09:54 +0100 [thread overview]
Message-ID: <52E26622.4070303@redhat.com> (raw)
In-Reply-To: <CAFEAcA9d7yOfGouWZpgm0ktC94Wqv+h2tCd9ccMKHGbRfyPbyQ@mail.gmail.com>
Il 24/01/2014 01:01, Peter Maydell ha scritto:
>> >
>> > +The 'data' member byte order is host kernel native endianness, regardless of
>> > +the endianness of the guest, and represents the the value as it would go on the
>> > +bus in real hardware. The host kernel should always be able to do:
>> > +<type> val = *((<type> *)mmio.data).
> I think this would be better phrased as "The host userspace should always",
> since this documentation is supposed to be telling userspace what the
> kernel's contract with it is, not the kernel keeping notes for itself on
> its own implementation. (It also clarifies what the intention is for the
> obscure and maybe-we'll-never-implement-this case of an LE host
> kernel using a compatibility interface to run the host userspace (QEMU)
> as a BE process which sees the same ABI a BE kernel provides,
> without actually dragging that red herring explicitly into the documentation.)
I agree, and also the first line should mention userspace.
In PPC I think it's possible or even common to have BE host kernel and
LE host userspace (or perhaps vice versa is the common one).
Paolo
next prev parent reply other threads:[~2014-01-24 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 23:46 [RFC PATCH] KVM: Specify byte order for KVM_EXIT_MMIO Christoffer Dall
2014-01-24 0:01 ` Peter Maydell
2014-01-24 13:09 ` Paolo Bonzini [this message]
2014-01-24 13:13 ` Alexander Graf
2014-01-24 15:23 ` Victor Kamensky
2014-01-24 15:32 ` Paolo Bonzini
2014-01-24 16:19 ` Victor Kamensky
2014-01-24 16:34 ` Victor Kamensky
2014-01-24 19:17 ` Victor Kamensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E26622.4070303@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=christoffer.dall@linaro.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox