From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH kvm-kmod] fix undefined kvm_vfio_ops Date: Fri, 24 Jan 2014 16:14:02 +0100 Message-ID: <52E2833A.3090608@siemens.com> References: <52E278AE.20505@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Jonas Pfoh , "kvm@vger.kernel.org" Return-path: Received: from thoth.sbs.de ([192.35.17.2]:49806 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752833AbaAXPON (ORCPT ); Fri, 24 Jan 2014 10:14:13 -0500 In-Reply-To: <52E278AE.20505@sec.in.tum.de> Sender: kvm-owner@vger.kernel.org List-ID: On 2014-01-24 15:29, Jonas Pfoh wrote: > vfio.c is being pulled in from the submodule, but it is not being compiled/linked by the build environment, causing a "Unknown symbol in module" error when loading the resulting module. > > Adding vfio.o to the kvm-objs variable in x86/Kbuild fixes this issue > > Signed-off-by: Jonas Pfoh > --- > > diff --git a/x86/Kbuild b/x86/Kbuild > index d75b756..637b3b1 100644 > --- a/x86/Kbuild > +++ b/x86/Kbuild > @@ -1,7 +1,7 @@ > obj-m := kvm.o kvm-intel.o kvm-amd.o > kvm-objs := kvm_main.o x86.o mmu.o emulate.o irq.o i8259.o pmu.o \ > lapic.o ioapic.o preempt.o i8254.o coalesced_mmio.o irq_comm.o \ > - eventfd.o compat-x86.o async_pf.o cpuid.o irqchip.o \ > + eventfd.o compat-x86.o async_pf.o cpuid.o irqchip.o vfio.o\ > ../external-module-compat.o > ifeq ($(CONFIG_IOMMU_API)$(CONFIG_PCI),yy) > kvm-objs += assigned-dev.o iommu.o > Format was almost perfect format - just your mailer mangled whitespaces. Make sure to either use git send-email then or to switch of line-wrapper etc. in the mail client when sending patches - to whichever project. Unfortunately it broke the build for 3.11 and older kernels. I merged a variant to next that passed build tests here. Thanks, Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux