From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [uq/master PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def() Date: Fri, 31 Jan 2014 12:42:42 +0100 Message-ID: <52EB8C32.5050901@redhat.com> References: <1391111339-6958-1-git-send-email-ehabkost@redhat.com> <1391111339-6958-5-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= , Igor Mammedov , kvm@vger.kernel.org, libvir-list@redhat.com, Jiri Denemark To: Eduardo Habkost , qemu-devel@nongnu.org Return-path: Received: from mail-ea0-f176.google.com ([209.85.215.176]:35327 "EHLO mail-ea0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753988AbaAaLms (ORCPT ); Fri, 31 Jan 2014 06:42:48 -0500 Received: by mail-ea0-f176.google.com with SMTP id h14so2258073eaj.35 for ; Fri, 31 Jan 2014 03:42:46 -0800 (PST) In-Reply-To: <1391111339-6958-5-git-send-email-ehabkost@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 30/01/2014 20:48, Eduardo Habkost ha scritto: > There isn't any kind of "registration" involved in cpu_x86_register() > anymore: it is simply looking up a CPU model name and loading the model > definition data into the X86CPU object. Rename it to x86_cpu_load_def() > to reflect what it does. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 0e8812a..58b4c71 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1817,7 +1817,9 @@ static void filter_features_for_kvm(X86CPU *cpu) > } > } > > -static void cpu_x86_register(X86CPU *cpu, const char *name, Error **errp) > +/* Load CPU definition for a given CPU model name > + */ > +static void x86_cpu_load_def(X86CPU *cpu, const char *name, Error **errp) > { > CPUX86State *env = &cpu->env; > x86_def_t def1, *def = &def1; > @@ -1900,7 +1902,7 @@ X86CPU *cpu_x86_create(const char *cpu_model, DeviceState *icc_bridge, > object_unref(OBJECT(cpu)); > #endif > > - cpu_x86_register(cpu, name, &error); > + x86_cpu_load_def(cpu, name, &error); > if (error) { > goto out; > } > Reviewed-by: Paolo Bonzini