From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7 Date: Fri, 31 Jan 2014 17:52:57 +0100 Message-ID: <52EBD4E9.2000700@redhat.com> References: <1391111339-6958-1-git-send-email-ehabkost@redhat.com> <20140131154853.34c41154@thinkpad> <52EBB82F.7020001@redhat.com> <20140131151753.GY2221@otherpad.lan.raisama.net> <20140131170621.3857e584@thinkpad> <20140131164207.GZ2221@otherpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, libvir-list@redhat.com, Jiri Denemark , =?ISO-8859-1?Q?Andreas_F=E4rber?= To: Eduardo Habkost , Igor Mammedov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43138 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932236AbaAaQxG (ORCPT ); Fri, 31 Jan 2014 11:53:06 -0500 In-Reply-To: <20140131164207.GZ2221@otherpad.lan.raisama.net> Sender: kvm-owner@vger.kernel.org List-ID: Il 31/01/2014 17:42, Eduardo Habkost ha scritto: >> > It looks like only -device would be able to create actual CPU models, >> > but for -device to work we need as minimum this series and conversion >> > of CPU features to properties in tree. Then I guess we can override >> > cannot_instantiate_with_device_add_yet for x86 CPUs. > Setting cannot_instantiate_with_device_add_yet=false looks much simpler > than implementing UserCreatable. My question is: may we do that, already > (once this series gets included), or is there something else holding us > from doing it? Once you make something creatable with "-object", the API must not change anymore. So we would have to think twice about that. Allowing -device may be okay, since in the (very?) long term -device can be replaced by -object. But -object is definitive. Paolo