From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] virtio: make udp more efficient by avoiding indirect desc Date: Wed, 12 Feb 2014 09:59:26 +0100 Message-ID: <52FB37EE.1090208@redhat.com> References: <52FA3AAC.2050003@huawei.com> <20140211154308.GA467@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: rusty@rustcorp.com.au, jasowang@redhat.com, KVM list To: "Michael S. Tsirkin" , Qin Chuanyu Return-path: Received: from mail-ea0-f181.google.com ([209.85.215.181]:44391 "EHLO mail-ea0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbaBLI7c (ORCPT ); Wed, 12 Feb 2014 03:59:32 -0500 Received: by mail-ea0-f181.google.com with SMTP id k10so2040320eaj.40 for ; Wed, 12 Feb 2014 00:59:31 -0800 (PST) In-Reply-To: <20140211154308.GA467@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 11/02/2014 16:43, Michael S. Tsirkin ha scritto: >> > Signed-off-by: Chuanyu Qin > Optimization patch without any performance data? > Such a change would need much more testing than that: > would have to try various workloads with -net and -blk at least. > -blk and -scsi never use 2 descriptors except for flushes (which go all the way to the platters or flash, and are not as frequent as other I/O). So the patch is in all likelihood a no-op there. Of course, virtio-net does need data. Paolo