From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH/RFC 2/3] s390/kvm: Platform specific kvm_arch_vcpu_dont_yield Date: Fri, 14 Feb 2014 10:56:15 +0100 Message-ID: <52FDE83F.3050607@redhat.com> References: <1392119132-50182-1-git-send-email-borntraeger@de.ibm.com> <1392119132-50182-3-git-send-email-borntraeger@de.ibm.com> <52FD4913.3000107@redhat.com> <52FD4D17.10307@de.ibm.com> <52FD5608.2050808@redhat.com> <52FDE813.5050809@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , KVM , linux-s390 , Cornelia Huck , Christian Ehrhardt To: Christian Borntraeger , Michael Mueller Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59887 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbaBNJ4Z (ORCPT ); Fri, 14 Feb 2014 04:56:25 -0500 In-Reply-To: <52FDE813.5050809@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 14/02/2014 10:55, Christian Borntraeger ha scritto: > OK. > Michael can you rework the series to simply use > " if (waitqueue_active(&vcpu->wq) && !kvm_arch_vcpu_runnable(vcpu)" in kvm_vcpu_on_spin > > and make kvm_arch_vcpu_runnable kvm_cpu_has_interrupt(vcpu) in s390 code? > That should be equivalent for s390 with even simpler code. > It might also help x86 and others. Exactly my point. ;) Paolo