From: Paolo Bonzini <pbonzini@redhat.com>
To: "Fernando Luis Vázquez Cao" <fernando_b1@lab.ntt.co.jp>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH v2] kvm: remove redundant registration of BSP's hv_clock area
Date: Tue, 18 Feb 2014 12:06:35 +0100 [thread overview]
Message-ID: <53033EBB.4000205@redhat.com> (raw)
In-Reply-To: <1392718151.12070.2.camel@nexus>
Il 18/02/2014 11:09, Fernando Luis Vázquez Cao ha scritto:
> These days hv_clock allocation is memblock based (i.e. the percpu
> allocator is not involved), which means that the physical address
> of each of the per-cpu hv_clock areas is guaranteed to remain
> unchanged through all its lifetime and we do not need to update
> its location after CPU bring-up.
>
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> ---
>
> diff -urNp linux-3.14-rc3-orig/arch/x86/kernel/kvm.c linux-3.14-rc3/arch/x86/kernel/kvm.c
> --- linux-3.14-rc3-orig/arch/x86/kernel/kvm.c 2014-02-18 19:01:08.103189324 +0900
> +++ linux-3.14-rc3/arch/x86/kernel/kvm.c 2014-02-18 19:01:45.412494366 +0900
> @@ -417,7 +417,6 @@ void kvm_disable_steal_time(void)
> #ifdef CONFIG_SMP
> static void __init kvm_smp_prepare_boot_cpu(void)
> {
> - WARN_ON(kvm_register_clock("primary cpu clock"));
> kvm_guest_cpu_init();
> native_smp_prepare_boot_cpu();
> kvm_spinlock_init();
> diff -urNp linux-3.14-rc3-orig/arch/x86/kernel/kvmclock.c linux-3.14-rc3/arch/x86/kernel/kvmclock.c
> --- linux-3.14-rc3-orig/arch/x86/kernel/kvmclock.c 2014-01-20 11:40:07.000000000 +0900
> +++ linux-3.14-rc3/arch/x86/kernel/kvmclock.c 2014-02-18 19:02:51.966823212 +0900
> @@ -242,7 +242,7 @@ void __init kvmclock_init(void)
> hv_clock = __va(mem);
> memset(hv_clock, 0, size);
>
> - if (kvm_register_clock("boot clock")) {
> + if (kvm_register_clock("primary cpu clock")) {
> hv_clock = NULL;
> memblock_free(mem, size);
> return;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Thanks, applying to kvm/queue.
Paolo
prev parent reply other threads:[~2014-02-18 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 7:37 [PATCH] kvm: remove redundant registration of BSP's hv_clock area Fernando Luis Vázquez Cao
2014-02-18 9:12 ` Paolo Bonzini
2014-02-18 10:09 ` [PATCH v2] " Fernando Luis Vázquez Cao
2014-02-18 11:06 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53033EBB.4000205@redhat.com \
--to=pbonzini@redhat.com \
--cc=fernando_b1@lab.ntt.co.jp \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox