From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Gleb Natapov <gleb@minantech.com>
Cc: KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
agraf@suse.de, mst@redhat.com
Subject: Re: [PATCHv2/RFC] kvm/irqchip: Speed up KVM_SET_GSI_ROUTING
Date: Fri, 21 Feb 2014 18:35:49 +0100 [thread overview]
Message-ID: <53078E75.2040603@redhat.com> (raw)
In-Reply-To: <1389876260-46636-1-git-send-email-borntraeger@de.ibm.com>
Il 16/01/2014 13:44, Christian Borntraeger ha scritto:
> +DEFINE_STATIC_SRCU(irq_srcu);
> +
> bool kvm_irq_has_notifier(struct kvm *kvm, unsigned irqchip, unsigned pin)
> {
> struct kvm_irq_ack_notifier *kian;
> - int gsi;
> + int gsi, idx;
>
> - rcu_read_lock();
> - gsi = rcu_dereference(kvm->irq_routing)->chip[irqchip][pin];
> + idx = srcu_read_lock(&irq_srcu);
> + gsi = srcu_dereference(kvm->irq_routing, &irq_srcu)->chip[irqchip][pin];
> if (gsi != -1)
> hlist_for_each_entry_rcu(kian, &kvm->irq_ack_notifier_list,
> link)
> @@ -45,7 +48,7 @@ bool kvm_irq_has_notifier(struct kvm *kvm, unsigned irqchip, unsigned pin)
> return true;
> }
>
> - rcu_read_unlock();
> + srcu_read_unlock(&irq_srcu, idx);
Missing hunk here:
@@ -44,7 +44,7 @@ bool kvm_irq_has_notifier(struct kvm *kvm, unsigned irqchip, unsigned pin)
hlist_for_each_entry_rcu(kian, &kvm->irq_ack_notifier_list,
link)
if (kian->gsi == gsi) {
- rcu_read_unlock();
+ srcu_read_unlock(&irq_srcu, idx);
return true;
}
Paolo
next prev parent reply other threads:[~2014-02-21 17:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 9:23 [PATCH] kvm/irqchip: Speed up KVM_SET_GSI_ROUTING Christian Borntraeger
2014-01-16 11:24 ` Paolo Bonzini
2014-01-16 12:44 ` [PATCHv2/RFC] " Christian Borntraeger
2014-01-16 12:59 ` Paolo Bonzini
2014-01-16 13:06 ` Christian Borntraeger
2014-01-16 13:07 ` Paolo Bonzini
2014-01-16 18:56 ` Michael S. Tsirkin
2014-01-17 8:29 ` Christian Borntraeger
2014-01-17 9:19 ` Paolo Bonzini
2014-02-19 22:23 ` Paolo Bonzini
2014-02-21 4:59 ` Andrew Theurer
2014-01-16 18:55 ` Michael S. Tsirkin
2014-01-16 20:07 ` [PATCHv3] " Christian Borntraeger
2014-01-16 20:22 ` Michael S. Tsirkin
2014-01-17 14:03 ` Paolo Bonzini
2014-01-17 15:03 ` Christian Borntraeger
2014-01-17 15:26 ` Paolo Bonzini
2014-02-21 17:35 ` Paolo Bonzini [this message]
2014-02-24 11:58 ` [PATCHv2] " Christian Borntraeger
2014-02-24 12:02 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53078E75.2040603@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@minantech.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).