Re: 3.10.X kernel/jump_label kvm

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2014-03-03 19:17, Stefan Priebe wrote:
> 
> Am 03.03.2014 17:36, schrieb Paolo Bonzini:
>> Il 28/02/2014 20:47, Stefan Priebe ha scritto:
>>> Hello,
>>>
>>> i got this stack trace multiple times while using a vanilla 3.10.32
>>> kernel and already sent it to the list in december but got no replies.
>>
>> Please try the patch of commit 0dce7cd67fd9055c4a2ff278f8af1431e646d346:
> 
> Thanks - will try it. So this one should also go into 3.10.X

It's part of 3.10.29. Only .26..28 were affected by the regression below.

Jan

>> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
>> index 1673940cf9c3..775702f649ca 100644
>> --- a/arch/x86/kvm/lapic.c
>> +++ b/arch/x86/kvm/lapic.c
>> @@ -1355,7 +1355,7 @@ void kvm_lapic_set_base(struct kvm_vcpu *vcpu, u64
>> value)
>>          vcpu->arch.apic_base = value;
>>
>>          /* update jump label if enable bit changes */
>> -       if ((vcpu->arch.apic_base ^ value) & MSR_IA32_APICBASE_ENABLE) {
>> +       if ((old_value ^ value) & MSR_IA32_APICBASE_ENABLE) {
>>                  if (value & MSR_IA32_APICBASE_ENABLE)
>>                          static_key_slow_dec_deferred(&apic_hw_disabled);
>>                  else
>>
>> Paolo
-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux