From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] [fix] kernel does not compile without CONFIG_KVM_ARM_VGIC Date: Tue, 04 Mar 2014 16:31:30 +0100 Message-ID: <5315F1D2.8070305@redhat.com> References: <1393945842-6453-1-git-send-email-m.paolino@virtualopensystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Michele Paolino , kvmarm@lists.cs.columbia.edu, tech@virtualopensystems.com, kvm@vger.kernel.org Return-path: Received: from mail-qa0-f42.google.com ([209.85.216.42]:38226 "EHLO mail-qa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbaCDPbg (ORCPT ); Tue, 4 Mar 2014 10:31:36 -0500 Received: by mail-qa0-f42.google.com with SMTP id k15so5034662qaq.1 for ; Tue, 04 Mar 2014 07:31:35 -0800 (PST) In-Reply-To: <1393945842-6453-1-git-send-email-m.paolino@virtualopensystems.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 04/03/2014 16:10, Michele Paolino ha scritto: > When the kernel is configured without CONFIG_KVM_ARM_VGIC, the > compilation process fails with : > > arch/arm/kvm/arm.c: In function 'kvm_vm_ioctl_set_device_addr': > arch/arm/kvm/arm.c:797:3: error: implicit declaration of > function 'kvm_vgic_addr' [-Werror=implicit-function-declaration] > return kvm_vgic_addr(kvm, type, &dev_addr->addr, true) > > Signed-off-by: Michele Paolino > --- > include/kvm/arm_vgic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/kvm/arm_vgic.h b/include/kvm/arm_vgic.h > index be85127..0bab057 100644 > --- a/include/kvm/arm_vgic.h > +++ b/include/kvm/arm_vgic.h > @@ -143,8 +143,8 @@ struct kvm_vcpu; > struct kvm_run; > struct kvm_exit_mmio; > > -#ifdef CONFIG_KVM_ARM_VGIC > int kvm_vgic_addr(struct kvm *kvm, unsigned long type, u64 *addr, bool write); > +#ifdef CONFIG_KVM_ARM_VGIC > int kvm_vgic_hyp_init(void); > int kvm_vgic_init(struct kvm *kvm); > int kvm_vgic_create(struct kvm *kvm); > Christoffer, Marc, I can queue this directly for kvm/master if it's okay for you. Paolo