From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH] virtio-scsi: Change sense buffer size to 252 Date: Thu, 06 Mar 2014 12:22:33 +0100 Message-ID: <53185A79.9010206@suse.de> References: <1394095660-15075-1-git-send-email-famz@redhat.com> <53184962.3080100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-scsi@vger.kernel.org, kvm@vger.kernel.org To: Paolo Bonzini , Fam Zheng , linux-kernel@vger.kernel.org Return-path: In-Reply-To: <53184962.3080100@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03/06/2014 11:09 AM, Paolo Bonzini wrote: > Il 06/03/2014 09:47, Fam Zheng ha scritto: >> According to SPC-4, section 4.5.2.1, 252 is the limit of sense >> data. So >> increase the value. >> >> Signed-off-by: Fam Zheng >> --- >> include/linux/virtio_scsi.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/virtio_scsi.h >> b/include/linux/virtio_scsi.h >> index 4195b97..a437f7f 100644 >> --- a/include/linux/virtio_scsi.h >> +++ b/include/linux/virtio_scsi.h >> @@ -28,7 +28,7 @@ >> #define _LINUX_VIRTIO_SCSI_H >> >> #define VIRTIO_SCSI_CDB_SIZE 32 >> -#define VIRTIO_SCSI_SENSE_SIZE 96 >> +#define VIRTIO_SCSI_SENSE_SIZE 252 >> >> /* SCSI command request, followed by data-out */ >> struct virtio_scsi_cmd_req { >> >=20 > Hi Fam, how did you test this? >=20 Is there a specific reason _not_ to use the linux default? The SCSI stack typically limits the sense code to SCSI_SENSE_BUFFERSIZE, so using other values have a limited sense. Literally :-) Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)