From: James Hogan <james.hogan@imgtec.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>,
<kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
Sanjay Lal <sanjayl@kymasys.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS
Date: Fri, 14 Mar 2014 09:42:11 +0000 [thread overview]
Message-ID: <5322CEF3.9010008@imgtec.com> (raw)
In-Reply-To: <53222304.3050902@suse.de>
Hi Andreas,
On 13/03/14 21:28, Andreas Färber wrote:
>> diff --git a/target-mips/kvm.c b/target-mips/kvm.c
>> new file mode 100644
>> index 0000000..0ec343d
>> --- /dev/null
>> +++ b/target-mips/kvm.c
> [...]
>> +static inline int kvm_mips_put_one_reg(CPUState *cs, int reg_id, int32 *addr)
>
> Did you mean int32_t?
>> +static inline int kvm_mips_get_one_reg(CPUState *cs, int reg_id, int32 *addr)
>
> int32_t?
>> + *addr = (int32)val64;
>
> int32_t?
> int32 is a type used in softfloat that has weird at-least-as-wide
> semantics and bit us in the past.
Well spotted, they should indeed be int32_t.
> Otherwise looking good now, thanks for the CPU cleanups! We just had
> another round of CPU refactorings go in today, but I don't spot a
> conflict in this patch. Please rebase your local branch to verify.
It rebased clearly, but I'll double check and send a v4 today anyway.
Thanks
James
next prev parent reply other threads:[~2014-03-14 9:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 17:09 [PATCH v3 0/9] KVM Support for MIPS32 Processors James Hogan
2014-03-06 17:09 ` [PATCH v3 1/9] hw/mips/cputimer: Don't start periodic timer in KVM mode James Hogan
2014-03-06 17:09 ` [PATCH v3 2/9] hw/mips: Add API to convert KVM guest KSEG0 <-> GPA James Hogan
2014-03-06 17:09 ` [PATCH v3 3/9] target-mips: get_physical_address: Add defines for segment bases James Hogan
2014-03-06 17:09 ` [PATCH v3 4/9] target-mips: get_physical_address: Add KVM awareness James Hogan
2014-03-06 17:09 ` [PATCH v3 5/9] kvm: Allow arch to set sigmask length James Hogan
2014-03-06 17:09 ` [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS James Hogan
2014-03-13 21:28 ` [Qemu-devel] " Andreas Färber
2014-03-13 22:35 ` Peter Maydell
2014-03-14 9:43 ` James Hogan
2014-03-14 12:53 ` Paolo Bonzini
2014-03-14 9:42 ` James Hogan [this message]
2014-03-06 17:09 ` [PATCH v3 7/9] hw/mips: In KVM mode, inject IRQ2 (I/O) interupts via ioctls James Hogan
2014-03-13 21:30 ` [Qemu-devel] " Andreas Färber
2014-03-06 17:09 ` [PATCH v3 8/9] hw/mips: malta: Add KVM support James Hogan
2014-03-06 17:09 ` [PATCH v3 9/9] target-mips: Enable KVM support in build system James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322CEF3.9010008@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox