From mboxrd@z Thu Jan  1 00:00:00 1970
From: James Hogan <james.hogan@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support
 for MIPS
Date: Fri, 14 Mar 2014 09:42:11 +0000
Message-ID: <5322CEF3.9010008@imgtec.com>
References: <1394125778-18746-1-git-send-email-james.hogan@imgtec.com> <1394125778-18746-7-git-send-email-james.hogan@imgtec.com> <53222304.3050902@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>,
	<kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
	Sanjay Lal <sanjayl@kymasys.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mailapp01.imgtec.com ([195.89.28.115]:37968 "EHLO
	mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755593AbaCNJmP (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 14 Mar 2014 05:42:15 -0400
In-Reply-To: <53222304.3050902@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Andreas,

On 13/03/14 21:28, Andreas F=C3=A4rber wrote:
>> diff --git a/target-mips/kvm.c b/target-mips/kvm.c
>> new file mode 100644
>> index 0000000..0ec343d
>> --- /dev/null
>> +++ b/target-mips/kvm.c
> [...]
>> +static inline int kvm_mips_put_one_reg(CPUState *cs, int reg_id, in=
t32 *addr)
>=20
> Did you mean int32_t?

>> +static inline int kvm_mips_get_one_reg(CPUState *cs, int reg_id, in=
t32 *addr)
>=20
> int32_t?

>> +    *addr =3D (int32)val64;
>=20
> int32_t?

> int32 is a type used in softfloat that has weird at-least-as-wide
> semantics and bit us in the past.

Well spotted, they should indeed be int32_t.

> Otherwise looking good now, thanks for the CPU cleanups! We just had
> another round of CPU refactorings go in today, but I don't spot a
> conflict in this patch. Please rebase your local branch to verify.

It rebased clearly, but I'll double check and send a v4 today anyway.

Thanks
James