From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS Date: Fri, 14 Mar 2014 09:43:16 +0000 Message-ID: <5322CF34.2020002@imgtec.com> References: <1394125778-18746-1-git-send-email-james.hogan@imgtec.com> <1394125778-18746-7-git-send-email-james.hogan@imgtec.com> <53222304.3050902@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , QEMU Developers , kvm-devel , Gleb Natapov , Sanjay Lal , Paolo Bonzini , Aurelien Jarno To: Peter Maydell Return-path: Received: from mailapp01.imgtec.com ([195.89.28.114]:34663 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755541AbaCNJnS (ORCPT ); Fri, 14 Mar 2014 05:43:18 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 13/03/14 22:35, Peter Maydell wrote: > On 13 March 2014 21:28, Andreas F=C3=A4rber wrote: >> I'm not sure if we have a policy about __u64 etc. in KVM code. Since >> it'll be Linux-only I don't see problems currently; for cross-platfo= rm >> parts we prefer uint64_t. Suggest to leave as is unless told otherwi= se. >=20 > For ARM I took the view that __u64 were the kernel's types, not > ours. The kernel header structs define fields as __u64 but for > in-QEMU functions and variables we should use the posix uint64_t. Thanks, I'll follow that way then. Cheers James