From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel] [PATCH v3 6/9] target-mips: kvm: Add main KVM support for MIPS Date: Fri, 14 Mar 2014 13:53:36 +0100 Message-ID: <5322FBD0.1000206@redhat.com> References: <1394125778-18746-1-git-send-email-james.hogan@imgtec.com> <1394125778-18746-7-git-send-email-james.hogan@imgtec.com> <53222304.3050902@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: James Hogan , QEMU Developers , kvm-devel , Gleb Natapov , Sanjay Lal , Aurelien Jarno To: Peter Maydell , =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19120 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753958AbaCNMyP (ORCPT ); Fri, 14 Mar 2014 08:54:15 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Il 13/03/2014 23:35, Peter Maydell ha scritto: >> > I'm not sure if we have a policy about __u64 etc. in KVM code. Since >> > it'll be Linux-only I don't see problems currently; for cross-platform >> > parts we prefer uint64_t. Suggest to leave as is unless told otherwise. > For ARM I took the view that __u64 were the kernel's types, not > ours. The kernel header structs define fields as __u64 but for > in-QEMU functions and variables we should use the posix uint64_t. Agree. Paolo