public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
	Igor Mammedov <imammedo@redhat.com>,
	linux-kernel@vger.kernel.org
Cc: gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com,
	x86@kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/2] KVM: x86 emulator: emulate MOVAPS and MOVAPD SSE instructions
Date: Mon, 17 Mar 2014 12:19:57 +0100	[thread overview]
Message-ID: <5326DA5D.7040503@redhat.com> (raw)
In-Reply-To: <f9c71833-f869-440c-8ab1-cd1f81f2da3b@email.android.com>

Il 15/03/2014 23:39, H. Peter Anvin ha scritto:
> MOVAPS, MOVAPD, and MOVDQA are the same operation.  They may, architecturally, have different performance characteristics, but nothing that would affect an emulator.

In fact MOVAPS and MOVAPD are implemented the same way in this patch:

I(Aligned, em_mov), I(Aligned, em_mov), N, N,

These are respectively for no prefix, 0x66, 0xf2 and 0xf3.  MOVDQA was 
already implemented, but on AMD some memcpy implementations use MOVAPS 
because it's a byte shorter.

Paolo

> On March 15, 2014 1:01:58 PM PDT, Igor Mammedov <imammedo@redhat.com> wrote:
>> MS HCK test fails on 32-bit Windows 8.1 due to missing MOVAPS
>> instruction emulation, this series adds it and while at it,
>> it adds emulation of MOVAPD which is trivial to implement on
>> top of MOVAPS.
>>
>> Igor Mammedov (2):
>>  KVM: x86 emulator: emulate MOVAPS
>>  KVM: x86 emulator: emulate MOVAPD
>>
>> arch/x86/kvm/emulate.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>

  reply	other threads:[~2014-03-17 11:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-15 20:01 [PATCH 0/2] KVM: x86 emulator: emulate MOVAPS and MOVAPD SSE instructions Igor Mammedov
2014-03-15 20:01 ` [PATCH 1/2] KVM: x86 emulator: emulate MOVAPS Igor Mammedov
2014-03-15 20:02 ` [PATCH 2/2] KVM: x86 emulator: emulate MOVAPD Igor Mammedov
2014-03-15 22:39 ` [PATCH 0/2] KVM: x86 emulator: emulate MOVAPS and MOVAPD SSE instructions H. Peter Anvin
2014-03-17 11:19   ` Paolo Bonzini [this message]
2014-03-15 22:42 ` H. Peter Anvin
2014-03-17  9:30   ` Paolo Bonzini
2014-03-17 15:16     ` H. Peter Anvin
2014-03-17 17:01       ` Paolo Bonzini
2014-03-17 17:38         ` H. Peter Anvin
2014-03-18 12:11           ` Paolo Bonzini
2014-03-17 11:18 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5326DA5D.7040503@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gleb@kernel.org \
    --cc=hpa@zytor.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox