From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/2] KVM: x86 emulator: emulate MOVAPS and MOVAPD SSE instructions Date: Mon, 17 Mar 2014 12:19:57 +0100 Message-ID: <5326DA5D.7040503@redhat.com> References: <1394913720-6466-1-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, kvm@vger.kernel.org To: "H. Peter Anvin" , Igor Mammedov , linux-kernel@vger.kernel.org Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 15/03/2014 23:39, H. Peter Anvin ha scritto: > MOVAPS, MOVAPD, and MOVDQA are the same operation. They may, architecturally, have different performance characteristics, but nothing that would affect an emulator. In fact MOVAPS and MOVAPD are implemented the same way in this patch: I(Aligned, em_mov), I(Aligned, em_mov), N, N, These are respectively for no prefix, 0x66, 0xf2 and 0xf3. MOVDQA was already implemented, but on AMD some memcpy implementations use MOVAPS because it's a byte shorter. Paolo > On March 15, 2014 1:01:58 PM PDT, Igor Mammedov wrote: >> MS HCK test fails on 32-bit Windows 8.1 due to missing MOVAPS >> instruction emulation, this series adds it and while at it, >> it adds emulation of MOVAPD which is trivial to implement on >> top of MOVAPS. >> >> Igor Mammedov (2): >> KVM: x86 emulator: emulate MOVAPS >> KVM: x86 emulator: emulate MOVAPD >> >> arch/x86/kvm/emulate.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >