From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PULL 3/4] KVM: s390: Fix possible memory leak in SIGP functions Date: Tue, 25 Mar 2014 15:39:41 +0100 Message-ID: <5331952D.4030408@de.ibm.com> References: <1395754523-43697-1-git-send-email-borntraeger@de.ibm.com> <1395754523-43697-4-git-send-email-borntraeger@de.ibm.com> <53318C82.80600@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: KVM , linux-s390 , Cornelia Huck , Thomas Huth To: Paolo Bonzini Return-path: Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:48505 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751787AbaCYOjr (ORCPT ); Tue, 25 Mar 2014 10:39:47 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Mar 2014 14:39:46 -0000 In-Reply-To: <53318C82.80600@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 25/03/14 15:02, Paolo Bonzini wrote: > Il 25/03/2014 14:35, Christian Borntraeger ha scritto: >> From: Thomas Huth >> >> When kvm_get_vcpu() returned NULL for the destination CPU in >> __sigp_emergency() or __sigp_external_call(), the memory for the >> "inti" structure was not released anymore. This patch fixes this >> issue by moving the check for !dst_vcpu before the kzalloc() call. >> >> Signed-off-by: Thomas Huth >> Reviewed-by: Cornelia Huck >> Signed-off-by: Christian Borntraeger > > Should patch 2 and this one have a Cc: stable? This bug is not yet in 3.14-rc It is only in kvm/next via commit 1ee0bc559dc34fe36a29494faf7b7c91533bd31c ( KVM: s390: get rid of local_int array) So no need for stable. patch 2 just reduces the memory usage from 64 bytes to 8 bytes. Dont think we should use the stable folks for that. Christian