Re: [PATCH v4 0/4] KVM: enable Intel SMAP for KVM

[Paolo Bonzini <pbonzini@redhat.com>]

Il 01/04/2014 11:46, Feng Wu ha scritto:
> Feng Wu (4):
>   KVM: Remove SMAP bit from CR4_RESERVED_BITS.
>   KVM: Add SMAP support when setting CR4
>   KVM: Disable SMAP for guests in EPT realmode and EPT unpaging mode
>   KVM: expose SMAP feature to guest
>

Hi,

I prepared some testcases.  You can find them in branch "smap" of 
git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git

To compile them for 32-bits:
	git clean -xdf
	./configure --arch=i386
	make
	./x86-run x86/smap.flat -cpu host

For 64-bits:
	git clean -xdf
	./configure
	make
	./x86-run x86/smap.flat -cpu host

I tried them with QEMU and they all pass.  The output should be 
something like this:

	enabling apic
	paging enabled
	cr0 = 80010011
	cr3 = 7fff000
	cr4 = 10
	testing without INVLPG
	PASS: write to supervisor page
	PASS: read from user page with AC=1
	PASS: read from user page with AC=0
	PASS: write to user page with AC=1
	PASS: read from user page with AC=0
	PASS: write to user stack with AC=1
	PASS: write to user stack with AC=0
	PASS: executing on user page with AC=0
	testing with INVLPG
	PASS: write to supervisor page
	PASS: read from user page with AC=1
	PASS: read from user page with AC=0
	PASS: write to user page with AC=1
	PASS: read from user page with AC=0
	PASS: write to user stack with AC=1
	PASS: write to user stack with AC=0
	PASS: executing on user page with AC=0
	
	SUMMARY: 16 tests, 0 failures

Please test them (both 32- and 64-bits) with both ept=1 and ept=0.  If 
the tests pass, the series is okay.

The only part that is not covered is the implicit kernel accesses at 
CPL=3, which QEMU doesn't implement that (I fixed it, but didn't have 
time to think about tests).  Since I'm going on vacation next week, I 
wanted to throw this out today.  I'll post the test patches when I'm back.

Paolo