From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
Ben Gardon <bgardon@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: fix overlap between SPTE_MMIO_MASK and generation
Date: Thu, 23 Jan 2020 13:16:53 +0100 [thread overview]
Message-ID: <533d3dd4-aa8e-07d0-2e8a-991fa758a366@redhat.com> (raw)
In-Reply-To: <20200121210405.GA12692@linux.intel.com>
On 21/01/20 22:04, Sean Christopherson wrote:
>> Alternatively, BUILD_BUG_ON((MMIO_SPTE_GEN_HIGH_MASK |
>> MMIO_SPTE_GEN_LOW_MASK) & SPTE_(MMIO and/or SPECIAL)_MASK)
> Or add both BUILD_BUG_ONs.
In the end I decided to revert MMIO_SPTE_GEN_HIGH_START to
PT64_SECOND_AVAIL_BITS_SHIFT (it makes sense since we use it for
shadow_acc_track_saved_bits_shift, and whether to use
shadow_acc_track_saved_bits_shift or MMIO_SPTE_GEN_HIGH_START depends on
the SPTE_SPECIAL_MASK bits) and use Ben's suggested BUILD_BUG_ON.
Paolo
next prev parent reply other threads:[~2020-01-23 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 16:11 [PATCH] KVM: x86: fix overlap between SPTE_MMIO_MASK and generation Paolo Bonzini
2020-01-21 17:24 ` Ben Gardon
2020-01-21 21:04 ` Sean Christopherson
2020-01-23 12:16 ` Paolo Bonzini [this message]
2020-01-22 14:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533d3dd4-aa8e-07d0-2e8a-991fa758a366@redhat.com \
--to=pbonzini@redhat.com \
--cc=bgardon@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox