From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: KVM: x86: remove WARN_ON from get_kernel_ns()
Date: Fri, 11 Apr 2014 20:06:34 -0400 [thread overview]
Message-ID: <5348838A.5060609@redhat.com> (raw)
In-Reply-To: <20140410211912.GA30474@amt.cnet>
Il 10/04/2014 17:19, Marcelo Tosatti ha scritto:
>
> Function and callers can be preempted.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=73721
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 2b85784..ee0c3b5 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1109,7 +1109,6 @@ static inline u64 get_kernel_ns(void)
> {
> struct timespec ts;
>
> - WARN_ON(preemptible());
> ktime_get_ts(&ts);
> monotonic_to_bootbased(&ts);
> return timespec_to_ns(&ts);
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
prev parent reply other threads:[~2014-04-12 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 21:19 KVM: x86: remove WARN_ON from get_kernel_ns() Marcelo Tosatti
2014-04-12 0:06 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5348838A.5060609@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).