From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 2/3] KVM: nVMX: Ack and write vector info to intr_info
 if L1 asks us to
Date: Sat, 12 Apr 2014 12:57:01 -0400
Message-ID: <5349705D.7030603@redhat.com>
References: <1396299625-8285-1-git-send-email-bsd@redhat.com> <1396299625-8285-3-git-send-email-bsd@redhat.com> <20140411183332.GA13157@amt.cnet> <jpgppknk750.fsf@nelium.bos.redhat.com> <20140411192007.GA19778@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>,
	Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, Bandan Das <bsd@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yh0-f50.google.com ([209.85.213.50]:42890 "EHLO
	mail-yh0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754800AbaDLQ5P (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 12 Apr 2014 12:57:15 -0400
Received: by mail-yh0-f50.google.com with SMTP id c41so6655234yho.9
        for <kvm@vger.kernel.org>; Sat, 12 Apr 2014 09:57:14 -0700 (PDT)
In-Reply-To: <20140411192007.GA19778@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 11/04/2014 15:20, Marcelo Tosatti ha scritto:
>>> > >
>>> > > Can irq be -1 ?
>> >
>> > If it is, I think that's a bug because if we exited for this
>> > reason with INTR_ACK set, the hypervisor expects a valid vector
>> > number to be available.
>> >
>> > What about adding a BUG_ON ?
> Sounds good.

Each BUG_ON we add to KVM is a potential guest-kill-host vulnerability. 
  WARN_ON is better.

Paolo