From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 1/3] migration dirtybitmap support ARMv7
Date: Tue, 15 Apr 2014 09:22:23 +0100
Message-ID: <534CEC3F.4090502@arm.com>
References: <534C8A3A.3060808@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
	=?UTF-8?B?7J207KCV7ISd?= <jays.lee@samsung.com>,
	=?UTF-8?B?7KCV7ISx7KeE?= <sungjinn.chung@samsung.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: Mario Smarduch <m.smarduch@samsung.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fw-tnat.austin.arm.com ([217.140.110.23]:36966 "EHLO
	collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1750865AbaDOIWb (ORCPT
	<rfc822;kvm@vger.kernel.org>); Tue, 15 Apr 2014 04:22:31 -0400
In-Reply-To: <534C8A3A.3060808@samsung.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Mario,

On 15/04/14 02:24, Mario Smarduch wrote:
> 
> Headers for migration, prototypes
> 
> Signed-off-by: Mario Smarduch <m.smarduch@samsung.com>

As a general comment in the whole series: Please take the time to write
decent commit messages. Having the same title for all three patches is
rather counter-productive, and I'd like to be able to tell what each
individual patch does just by reading the commit message.

Thanks!

> ---
>  arch/arm/include/asm/kvm_host.h |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
> index 098f7dd..9b71f13 100644
> --- a/arch/arm/include/asm/kvm_host.h
> +++ b/arch/arm/include/asm/kvm_host.h
> @@ -67,6 +67,7 @@ struct kvm_arch {
>  
>  	/* Interrupt controller */
>  	struct vgic_dist	vgic;
> +	int migration_in_progress;
>  };
>  
>  #define KVM_NR_MEM_OBJS     40
> @@ -228,4 +229,12 @@ int kvm_perf_teardown(void);
>  u64 kvm_arm_timer_get_reg(struct kvm_vcpu *, u64 regid);
>  int kvm_arm_timer_set_reg(struct kvm_vcpu *, u64 regid, u64 value);
>  
> +void kvm_mmu_slot_remove_write_access(struct kvm *kvm, int slot);
> +
> +void kvm_mmu_write_protect_pt_masked(struct kvm *kvm,
> +		struct kvm_memory_slot *slot,
> +		gfn_t gfn_offset, unsigned long mask);
> +
> +void kvm_tlb_flush_vmid(struct kvm *kvm);
> +
>  #endif /* __ARM_KVM_HOST_H__ */
> 

This doesn't make much sense on its own. Consider squashing it in
another patch.

	M.
-- 
Jazz is not dead. It just smells funny...