From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 3/3] migration dirtybitmap support ARMv7 Date: Wed, 16 Apr 2014 10:51:35 +0200 Message-ID: <534E4497.2050006@de.ibm.com> References: <534C8A4C.5040008@samsung.com> <534CF6B2.6020606@arm.com> <534DDBD8.30502@samsung.com> <534E3BA6.4050503@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "eric.auger@linaro.org" , "kvmarm@lists.cs.columbia.edu" , "christoffer.dall@linaro.org" , =?UTF-8?B?7J207KCV7ISd?= , =?UTF-8?B?7KCV7ISx7KeE?= , "kvm@vger.kernel.org" To: Marc Zyngier , Mario Smarduch Return-path: Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:37272 "EHLO e06smtp18.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752354AbaDPIvo (ORCPT ); Wed, 16 Apr 2014 04:51:44 -0400 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 Apr 2014 09:51:42 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id A85C917D8056 for ; Wed, 16 Apr 2014 09:52:34 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s3G8pciV51708012 for ; Wed, 16 Apr 2014 08:51:38 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s3G8pb1F016575 for ; Wed, 16 Apr 2014 02:51:38 -0600 In-Reply-To: <534E3BA6.4050503@arm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 16/04/14 10:13, Marc Zyngier wrote: > Hi Mario, > > On 16/04/14 02:24, Mario Smarduch wrote: >> Hi Eric, Mark - >> what repository should I use to pick up Eric patches? > > The initial posting was there: > > https://lists.cs.columbia.edu/pipermail/kvmarm/2014-April/008791.html > > Reading Eric's patch again, it is not doing exactly the same thing, but > actually dealing with a slightly different (but connected) case. > > I suggest you both work together on a common patch (or patch series) > that deals with the various memory region change thingy. > >> For kvm_vm_ioctl_get_dirty_log() not sure what to make generic >> it appears generic enough and it does what it needs to do? > > What I'm saying is that it should be put in a common location > (virt/kvm/kvm_main.c?), possibly as a weak symbol so it can be > overridden by other architectures. Yes, make it weak. The s390 implementation looks different.