From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [kvm-kmod PATCH 2/2] sync: copy linux/vfio.h from kvm source tree Date: Tue, 22 Apr 2014 16:57:32 +0200 Message-ID: <5356835C.1040009@siemens.com> References: <20140422145202.GB1630@ERROL.INI.CMU.EDU> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: gsomlo@gmail.com Return-path: Received: from thoth.sbs.de ([192.35.17.2]:58312 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932872AbaDVO5g (ORCPT ); Tue, 22 Apr 2014 10:57:36 -0400 In-Reply-To: <20140422145202.GB1630@ERROL.INI.CMU.EDU> Sender: kvm-owner@vger.kernel.org List-ID: On 2014-04-22 16:52, gsomlo@gmail.com wrote: > Signed-off-by: Gabriel Somlo > --- > > vfio.c gets copied by sync, and it needs vfio.h. I don't think there's > an easy way to #define ourselves out of this one, copying vfio.h into > kvm-kmod/include/linux/ seems to be the path of least resistance... > > Thanks, > Gabriel > > P.S. I'm not a native Python speaker, so, while the glob() line does the > job, it may not be the most beautiful way to express the new requirement :) I've a different mother languages as well ;). Did you try if ...linux/{kvm*,vfio}.h works? If we have shell power here for pattern matching, it should. Jan > > sync | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sync b/sync > index e447ec4..9902a11 100755 > --- a/sync > +++ b/sync > @@ -433,6 +433,7 @@ def header_sync(arch): > T = 'header' > rmtree(T) > for file in (glob('%(linux)s/include/linux/kvm*.h' % { 'linux': linux }) + > + glob('%(linux)s/include/linux/vfio.h' % { 'linux': linux }) + > glob('%(linux)s/include/uapi/linux/kvm*.h' % { 'linux': linux })): > out = ('%(T)s/include/linux/%(name)s' > % { 'T': T, 'name': os.path.basename(file) }) > -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux