From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [patch 1/2] target-i386: support "invariant tsc" flag Date: Tue, 22 Apr 2014 20:26:36 -0400 Message-ID: <535708BC.5060704@redhat.com> References: <20140422191042.005048158@amt.cnet> <20140422191200.328459410@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Eduardo Habkost To: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org Return-path: Received: from mail-qg0-f44.google.com ([209.85.192.44]:40163 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbaDWA0j (ORCPT ); Tue, 22 Apr 2014 20:26:39 -0400 Received: by mail-qg0-f44.google.com with SMTP id q108so237302qgd.17 for ; Tue, 22 Apr 2014 17:26:38 -0700 (PDT) In-Reply-To: <20140422191200.328459410@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Il 22/04/2014 15:10, Marcelo Tosatti ha scritto: > + case 0x80000007: > + *eax = 0; > + *ebx = 0; > + *ecx = 0; > + > + if (kvm_enabled()) { > + *edx = env->features[FEAT_8000_0007_EDX]; > + } else { > + *edx = 0; > + } I think TCG is able to eliminate unsupported features too before they get in env->features[]. Or are those patches not in yet? Eduardo? Paolo