From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [kvm-kmod PATCH 2/2] sync: copy linux/vfio.h from kvm source
 tree
Date: Wed, 23 Apr 2014 08:00:09 +0200
Message-ID: <535756E9.1010402@siemens.com>
References: <20140422145202.GB1630@ERROL.INI.CMU.EDU> <5356835C.1040009@siemens.com> <20140422184342.GD1630@ERROL.INI.CMU.EDU>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from thoth.sbs.de ([192.35.17.2]:60895 "EHLO thoth.sbs.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753260AbaDWGAM (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 23 Apr 2014 02:00:12 -0400
In-Reply-To: <20140422184342.GD1630@ERROL.INI.CMU.EDU>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2014-04-22 20:43, Gabriel L. Somlo wrote:
> On Tue, Apr 22, 2014 at 04:57:32PM +0200, Jan Kiszka wrote:
>> On 2014-04-22 16:52, gsomlo@gmail.com wrote:
>>> Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
>>> ---
>>>
>>> vfio.c gets copied by sync, and it needs vfio.h. I don't think there's
>>> an easy way to #define ourselves out of this one, copying vfio.h into
>>> kvm-kmod/include/linux/ seems to be the path of least resistance...
>>>
>>> Thanks,
>>>    Gabriel
>>>
>>> P.S. I'm not a native Python speaker, so, while the glob() line does the
>>> job, it may not be the most beautiful way to express the new requirement :)
>>
>> I've a different mother languages as well ;).
>>
>> Did you try if ...linux/{kvm*,vfio}.h works? If we have shell power here
>> for pattern matching, it should.
> 
> I played around a bit, and I couldn't find a way to do full regex for
> a glob() argument.
> 
> You can pick from a set of characters at a time:
> 
> 'foo[0-9]bar' would match 'foo0bar', 'foo1bar', etc.
> 
> But nothing I found allows you to pick from a set of *substrings*,
> which is what we'd need:
> 
> 'foo(xyz|abc)bar' to match 'fooxyzbar' and 'fooabcbar' (but *not* say,
> 'foo123bar').
> 
> I tried parentheses, curly braces, with and without '\', with no success.
> 
> Not sure at this point there *is* a more eloquent way to express it
> than what I sent you originally.
> 
> Learning Python *is* on my bucket list, just not right this minute... :)

Anyway, thanks for the patches - merged now as-is.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux