From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs Date: Sat, 26 Apr 2014 11:42:37 +0200 Message-ID: <535B7F8D.10609@redhat.com> References: <5355E222.7010607@redhat.com> <5356BF6A.2070801@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti , Gleb Natapov , linux-kernel@vger.kernel.org To: Bandan Das Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 22/04/2014 21:31, Bandan Das ha scritto: > Paolo Bonzini writes: > >> Il 22/04/2014 12:25, Bandan Das ha scritto: >>>>>>> + if (j < i) >>>>>>> + shadow_read_write_fields[j] = >>>>>>> + shadow_read_write_fields[i]; >>>>>>> + j++; >>>>> >>>>> ... you need to respin anyway because the j++ is wrong. It should be >>>>> inside the "if". If you prefer, you can put it in the lhs of the >>> j++ outside the "if" looks right to me. Can you please explain why >>> you think it shouldn't be that way ? >>> >> >> The way you wrote it, j will always be equal to i. > > Right, and that's what we want unless we come across an unsupported > field. We then overwrite the unsupported field with the next > field supported. j this way keeps track of the "real" length. Doh, brain fart. Paolo