From: "Toralf Förster" <toralf.foerster@gmx.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition
Date: Sun, 27 Apr 2014 17:29:30 +0200 [thread overview]
Message-ID: <535D225A.4020505@gmx.de> (raw)
In-Reply-To: <535D171D.7020809@redhat.com>
On 04/27/2014 04:41 PM, Paolo Bonzini wrote:
> Il 27/04/2014 13:40, Toralf Förster ha scritto:
>> Ah, so the following would work, but looks too ugly, right ? :
>>
>>
>> #ifdef CONFIG_X86_64
>> if (!longmode) {
>> #endif
>> param = ((u64)kvm_register_read(vcpu, VCPU_REGS_RDX) << 32) |
>> (kvm_register_read(vcpu, VCPU_REGS_RAX) & 0xffffffff);
>> ingpa = ((u64)kvm_register_read(vcpu, VCPU_REGS_RBX) << 32) |
>> (kvm_register_read(vcpu, VCPU_REGS_RCX) & 0xffffffff);
>> outgpa = ((u64)kvm_register_read(vcpu, VCPU_REGS_RDI) << 32) |
>> (kvm_register_read(vcpu, VCPU_REGS_RSI) & 0xffffffff);
>> #ifdef CONFIG_X86_64
>> }
>> else {
>> param = kvm_register_read(vcpu, VCPU_REGS_RCX);
>> ingpa = kvm_register_read(vcpu, VCPU_REGS_RDX);
>> outgpa = kvm_register_read(vcpu, VCPU_REGS_R8);
>> }
>> #endif
>>
>
> Yep. :) Note that GCC correctly reports no warning, because it looks
> through is_long_mode. In the end, #ifdef in the code can just be
> removed. Please compile-test it on 32-bit though (well, I will too
> before committing but...).
>
> Paolo
>
Will send out a patch, which was compile tested and runtime tested using
a tails KVM image udner a stable 32 bit Gentoo Linux
--
Toralf
prev parent reply other threads:[~2014-04-27 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 10:30 [PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition Toralf Förster
2014-04-27 10:30 ` [PATCH 2/2] arch/x86/kvm/x86.c: variable longmode ist just used in one place, remove it therefore Toralf Förster
2014-04-27 10:45 ` [PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition Paolo Bonzini
2014-04-27 11:40 ` Toralf Förster
2014-04-27 14:41 ` Paolo Bonzini
2014-04-27 15:29 ` Toralf Förster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535D225A.4020505@gmx.de \
--to=toralf.foerster@gmx.de \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox