From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?VG9yYWxmIEbDtnJzdGVy?= Subject: Re: [PATCH 1/2] arch/x86/kvm/x86.c: remove superflous check condition Date: Sun, 27 Apr 2014 17:29:30 +0200 Message-ID: <535D225A.4020505@gmx.de> References: <1398594613-4466-1-git-send-email-toralf.foerster@gmx.de> <535CDFBE.5050806@redhat.com> <535CECB6.5070802@gmx.de> <535D171D.7020809@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mout.gmx.net ([212.227.17.20]:62616 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbaD0P3j (ORCPT ); Sun, 27 Apr 2014 11:29:39 -0400 In-Reply-To: <535D171D.7020809@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/27/2014 04:41 PM, Paolo Bonzini wrote: > Il 27/04/2014 13:40, Toralf F=C3=B6rster ha scritto: >> Ah, so the following would work, but looks too ugly, right ? : >> >> >> #ifdef CONFIG_X86_64 >> if (!longmode) { >> #endif >> param =3D ((u64)kvm_register_read(vcpu, VCPU_REGS_RDX) << 32= ) | >> (kvm_register_read(vcpu, VCPU_REGS_RAX) & 0xffffffff); >> ingpa =3D ((u64)kvm_register_read(vcpu, VCPU_REGS_RBX) << 32= ) | >> (kvm_register_read(vcpu, VCPU_REGS_RCX) & 0xffffffff); >> outgpa =3D ((u64)kvm_register_read(vcpu, VCPU_REGS_RDI) << 3= 2) | >> (kvm_register_read(vcpu, VCPU_REGS_RSI) & 0xffffffff); >> #ifdef CONFIG_X86_64 >> } >> else { >> param =3D kvm_register_read(vcpu, VCPU_REGS_RCX); >> ingpa =3D kvm_register_read(vcpu, VCPU_REGS_RDX); >> outgpa =3D kvm_register_read(vcpu, VCPU_REGS_R8); >> } >> #endif >> >=20 > Yep. :) Note that GCC correctly reports no warning, because it looks > through is_long_mode. In the end, #ifdef in the code can just be > removed. Please compile-test it on 32-bit though (well, I will too > before committing but...). >=20 > Paolo >=20 Will send out a patch, which was compile tested and runtime tested usin= g a tails KVM image udner a stable 32 bit Gentoo Linux --=20 Toralf