From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] arch/x86/kvm/x86.c: remove a superfluous test for !X86_64 Date: Sun, 27 Apr 2014 17:40:41 +0200 Message-ID: <535D24F9.7080605@redhat.com> References: <1398612730-6684-1-git-send-email-toralf.foerster@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org To: =?UTF-8?B?VG9yYWxmIEbDtnJzdGVy?= Return-path: Received: from mail-ee0-f47.google.com ([74.125.83.47]:63228 "EHLO mail-ee0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751858AbaD0Pks (ORCPT ); Sun, 27 Apr 2014 11:40:48 -0400 Received: by mail-ee0-f47.google.com with SMTP id b15so4103006eek.20 for ; Sun, 27 Apr 2014 08:40:47 -0700 (PDT) In-Reply-To: <1398612730-6684-1-git-send-email-toralf.foerster@gmx.de> Sender: kvm-owner@vger.kernel.org List-ID: Il 27/04/2014 17:32, Toralf F=C3=B6rster ha scritto: > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 8b8fc0b..a6ca7e0 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -5680,15 +5680,17 @@ int kvm_hv_hypercall(struct kvm_vcpu *vcpu) > kvm_x86_ops->get_cs_db_l_bits(vcpu, &cs_db, &cs_l); > longmode =3D is_long_mode(vcpu) && cs_l =3D=3D 1; > > +#ifdef CONFIG_X86_64 > if (!longmode) { > +#endif This is ugly... > param =3D ((u64)kvm_register_read(vcpu, VCPU_REGS_RDX) << 32) | > (kvm_register_read(vcpu, VCPU_REGS_RAX) & 0xffffffff); > ingpa =3D ((u64)kvm_register_read(vcpu, VCPU_REGS_RBX) << 32) | > (kvm_register_read(vcpu, VCPU_REGS_RCX) & 0xffffffff); > outgpa =3D ((u64)kvm_register_read(vcpu, VCPU_REGS_RDI) << 32) | > (kvm_register_read(vcpu, VCPU_REGS_RSI) & 0xffffffff); > - } > #ifdef CONFIG_X86_64 =2E.. can you just remove this #ifdef instead? It will be dead code, b= ut=20 the compiler will detect it as such and remove it. Paolo > + } > else { > param =3D kvm_register_read(vcpu, VCPU_REGS_RCX); > ingpa =3D kvm_register_read(vcpu, VCPU_REGS_RDX);