* [PATCH kvm-unit-tests] x86/debug: return report_summary
@ 2014-04-23 12:01 Andrew Jones
2014-04-28 9:16 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Jones @ 2014-04-23 12:01 UTC (permalink / raw)
To: kvm; +Cc: pbonzini, mtosatti
run_tests always reported 'PASS debug', even when subtests were
failing. Fix that.
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
x86/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/debug.c b/x86/debug.c
index 154c7fe4db66d..34e56fbeadc3e 100644
--- a/x86/debug.c
+++ b/x86/debug.c
@@ -109,5 +109,5 @@ hw_wp:
n == 1 &&
bp_addr[0] == ((unsigned long)&&hw_wp) && dr6[0] == 0xffff4ff2);
- return 0;
+ return report_summary();
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH kvm-unit-tests] x86/debug: return report_summary
2014-04-23 12:01 [PATCH kvm-unit-tests] x86/debug: return report_summary Andrew Jones
@ 2014-04-28 9:16 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-04-28 9:16 UTC (permalink / raw)
To: Andrew Jones, kvm; +Cc: mtosatti
Il 23/04/2014 14:01, Andrew Jones ha scritto:
> run_tests always reported 'PASS debug', even when subtests were
> failing. Fix that.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> x86/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/debug.c b/x86/debug.c
> index 154c7fe4db66d..34e56fbeadc3e 100644
> --- a/x86/debug.c
> +++ b/x86/debug.c
> @@ -109,5 +109,5 @@ hw_wp:
> n == 1 &&
> bp_addr[0] == ((unsigned long)&&hw_wp) && dr6[0] == 0xffff4ff2);
>
> - return 0;
> + return report_summary();
> }
Applying, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-28 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-23 12:01 [PATCH kvm-unit-tests] x86/debug: return report_summary Andrew Jones
2014-04-28 9:16 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox