From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/2] KVM: async_pf: use_mm/mm_users fixes Date: Mon, 28 Apr 2014 13:06:05 +0200 Message-ID: <535E361D.3050902@redhat.com> References: <20140421132543.GA13594@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Dominik Dingel , Christian Borntraeger , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Andrea Arcangeli To: Oleg Nesterov , Avi Kivity , Gleb Natapov Return-path: In-Reply-To: <20140421132543.GA13594@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 21/04/2014 15:25, Oleg Nesterov ha scritto: > Hello. > > Completely untested and I know nothing about kvm ;) Please review. > > But use_mm() really looks misleading, and the usage of mm_users looks > "obviously wrong". I already sent this change while we were discussing > vmacache, but it was ignored. Since then kvm_async_page_present_sync() > was added into async_pf_execute() into async_pf_execute(), but it seems > to me that use_mm() is still unnecessary. > > Oleg. > > virt/kvm/async_pf.c | 10 ++++------ > 1 files changed, 4 insertions(+), 6 deletions(-) > Applying patch 2 to kvm/master (for 3.15). Patch 1 will be for 3.16 only, I'd like a review from Marcelo or Andrea though (that's "KVM: async_pf: kill the unnecessary use_mm/unuse_mm async_pf_execute()" for easier googling). Paolo