From: Paolo Bonzini <pbonzini@redhat.com>
To: Ulrich Obergfell <uobergfe@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 1/1] KVM: x86: improve the usability of the 'kvm_pio' tracepoint
Date: Mon, 05 May 2014 22:41:50 +0200 [thread overview]
Message-ID: <5367F78E.9010006@redhat.com> (raw)
In-Reply-To: <1399046267-4677-2-git-send-email-uobergfe@redhat.com>
Il 02/05/2014 17:57, Ulrich Obergfell ha scritto:
> This patch moves the 'kvm_pio' tracepoint to emulator_pio_in_emulated()
> and emulator_pio_out_emulated(), and it adds an argument (a pointer to
> the 'pio_data'). A single 8-bit or 16-bit or 32-bit data item is fetched
> from 'pio_data' (depending on 'size'), and the value is included in the
> trace record ('val'). If 'count' is greater than one, this is indicated
> by the string "(...)" in the trace output.
A difference is that the tracepoint will be reported after an exit to
userspace in the case of "in", rather than before.
The improvement however is noticeable; especially for "out" it allows to
obtain much more information about the state of a device from a long
trace. Applying to kvm/queue, thanks.
Paolo
next prev parent reply other threads:[~2014-05-05 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 15:57 [PATCH 0/1] KVM: x86: improve the usability of the 'kvm_pio' tracepoint Ulrich Obergfell
2014-05-02 15:57 ` [PATCH 1/1] " Ulrich Obergfell
2014-05-05 20:41 ` Paolo Bonzini [this message]
2014-05-05 7:10 ` [PATCH 0/1] " Xiao Guangrong
2014-05-05 17:11 ` Ulrich Obergfell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5367F78E.9010006@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox