From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/1] KVM: x86: improve the usability of the 'kvm_pio' tracepoint Date: Mon, 05 May 2014 22:41:50 +0200 Message-ID: <5367F78E.9010006@redhat.com> References: <1399046267-4677-1-git-send-email-uobergfe@redhat.com> <1399046267-4677-2-git-send-email-uobergfe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit To: Ulrich Obergfell , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:35175 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753536AbaEEUly (ORCPT ); Mon, 5 May 2014 16:41:54 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s45KfrwO007015 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 5 May 2014 16:41:53 -0400 In-Reply-To: <1399046267-4677-2-git-send-email-uobergfe@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 02/05/2014 17:57, Ulrich Obergfell ha scritto: > This patch moves the 'kvm_pio' tracepoint to emulator_pio_in_emulated() > and emulator_pio_out_emulated(), and it adds an argument (a pointer to > the 'pio_data'). A single 8-bit or 16-bit or 32-bit data item is fetched > from 'pio_data' (depending on 'size'), and the value is included in the > trace record ('val'). If 'count' is greater than one, this is indicated > by the string "(...)" in the trace output. A difference is that the tracepoint will be reported after an exit to userspace in the case of "in", rather than before. The improvement however is noticeable; especially for "out" it allows to obtain much more information about the state of a device from a long trace. Applying to kvm/queue, thanks. Paolo