From: Paolo Bonzini <pbonzini@redhat.com>
To: Abel Gordon <abel@stratoscale.com>
Cc: Hu Yaohui <loki2441@gmail.com>, Bandan Das <bsd@redhat.com>,
kvm <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Muli Ben-Yehuda <muli@stratoscale.com>
Subject: Re: KVM Nested L2 guest startup problems
Date: Wed, 07 May 2014 17:41:06 +0200 [thread overview]
Message-ID: <536A5412.5000403@redhat.com> (raw)
In-Reply-To: <CAESbUUyxxLLdmN5oV+NoOF+4z9-xAc6AOXPD7_XhSQ9sKvZYBA@mail.gmail.com>
Il 07/05/2014 17:30, Abel Gordon ha scritto:
> > ... which we already do. The only secondary execution controls we allow are
> > APIC page, unrestricted guest, WBINVD exits, and of course EPT.
>
> But we don't verify if L1 tries to enable the feature for L1 (even if
> it's not exposed)... Or do we ?
Yes, we do:
if (!vmx_control_verify(vmcs12->cpu_based_vm_exec_control,
nested_vmx_procbased_ctls_low, nested_vmx_procbased_ctls_high) ||
!vmx_control_verify(vmcs12->secondary_vm_exec_control,
nested_vmx_secondary_ctls_low, nested_vmx_secondary_ctls_high) ||
!vmx_control_verify(vmcs12->pin_based_vm_exec_control,
nested_vmx_pinbased_ctls_low, nested_vmx_pinbased_ctls_high) ||
!vmx_control_verify(vmcs12->vm_exit_controls,
nested_vmx_exit_ctls_low, nested_vmx_exit_ctls_high) ||
!vmx_control_verify(vmcs12->vm_entry_controls,
nested_vmx_entry_ctls_low, nested_vmx_entry_ctls_high))
{
nested_vmx_failValid(vcpu, VMXERR_ENTRY_INVALID_CONTROL_FIELD);
return 1;
}
Paolo
prev parent reply other threads:[~2014-05-07 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 1:43 KVM Nested L2 guest startup problems Hu Yaohui
2014-05-02 9:53 ` Paolo Bonzini
2014-05-02 15:17 ` Hu Yaohui
2014-05-02 15:52 ` Paolo Bonzini
2014-05-02 17:07 ` Hu Yaohui
2014-05-02 18:39 ` Bandan Das
2014-05-02 20:11 ` Hu Yaohui
2014-05-04 14:57 ` Abel Gordon
2014-05-04 16:33 ` Hu Yaohui
2014-05-07 8:58 ` Paolo Bonzini
2014-05-07 11:16 ` Abel Gordon
2014-05-07 11:37 ` Paolo Bonzini
2014-05-07 11:40 ` Paolo Bonzini
2014-05-07 15:30 ` Abel Gordon
2014-05-07 15:41 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A5412.5000403@redhat.com \
--to=pbonzini@redhat.com \
--cc=abel@stratoscale.com \
--cc=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loki2441@gmail.com \
--cc=muli@stratoscale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).