From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 11/11] kvm tools: Modify term_putc to write more than
 one char
Date: Wed, 07 May 2014 19:58:30 +0400
Message-ID: <536A5826.6010008@cogentembedded.com>
References: <1399391491-5021-1-git-send-email-andreas.herrmann@caviumnetworks.com> <1399391491-5021-12-git-send-email-andreas.herrmann@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: David Daney <ddaney.cavm@gmail.com>, kvm@vger.kernel.org,
	linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>
To: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>,
	Pekka Enberg <penberg@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-lb0-f181.google.com ([209.85.217.181]:53869 "EHLO
	mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756958AbaEGP6Q (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 7 May 2014 11:58:16 -0400
Received: by mail-lb0-f181.google.com with SMTP id u14so1651023lbd.26
        for <kvm@vger.kernel.org>; Wed, 07 May 2014 08:58:15 -0700 (PDT)
In-Reply-To: <1399391491-5021-12-git-send-email-andreas.herrmann@caviumnetworks.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hello.

On 06-05-2014 19:51, Andreas Herrmann wrote:

> From: David Daney <david.daney@cavium.com>

> It is a performance enhancement. When running in a simulator, each
> system call to write a character takes a lot of time.  Batching them
> up decreases the overhead (in the root kernel) of each virtio console
> write.

> Signed-off-by: David Daney <david.daney@cavium.com>
> Signed-off-by: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
> ---
>   tools/kvm/term.c |    7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)

> diff --git a/tools/kvm/term.c b/tools/kvm/term.c
> index 3de410b..b153eed 100644
> --- a/tools/kvm/term.c
> +++ b/tools/kvm/term.c
> @@ -52,11 +52,14 @@ int term_getc(struct kvm *kvm, int term)
>   int term_putc(char *addr, int cnt, int term)
>   {
>   	int ret;
> +	int num_remaining = cnt;
>
> -	while (cnt--) {
> -		ret = write(term_fds[term][TERM_FD_OUT], addr++, 1);
> +	while (num_remaining) {
> +		ret = write(term_fds[term][TERM_FD_OUT], addr, num_remaining);
>   		if (ret < 0)
>   			return 0;

    Perhaps 'return cnt - num_remaining' instead?

> +		num_remaining -= ret;
> +		addr += ret;
>   	}
>
>   	return cnt;

WBR, Sergei