From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Henderson Subject: Re: [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF Date: Mon, 19 May 2014 09:50:06 -0700 Message-ID: <537A363E.309@twiddle.net> References: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com> <1400367823-32610-4-git-send-email-marc.mari.barcelo@gmail.com> <20140519184526.00364e81@crunchbang> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Stefan Hajnoczi , Overall , Alexander Graf , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "qemu-devel@nongnu.org Developers" To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= , Peter Crosthwaite Return-path: In-Reply-To: <20140519184526.00364e81@crunchbang> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 05/19/2014 09:45 AM, Marc Marí wrote: >> > This STDOUT vs _log() choice is a bit irregular, and I think you might >> > be better off abandoning it completely. Richard, Alex, do we really >> > need to optionally route printfery to log or stderr? (considering _log >> > is NOW stderr by default now, and -D option gives you some flexibility >> > there). Can we have just log and drop STDOUT mode? >> > >> > Regards, >> > Peter > QEMU_DPRINTF outputs to stderr, and, as you say qemu_log does it too. > Should QEMU_DPRINTF be removed and leave only qemu_log? Yes, I think that all debug output like this should go via qemu_log. r~