From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to
 QEMU_DPRINTF
Date: Mon, 19 May 2014 22:34:58 +0200
Message-ID: <537A6AF2.4030307@suse.de>
References: <1400367823-32610-1-git-send-email-marc.mari.barcelo@gmail.com>	<1400367823-32610-4-git-send-email-marc.mari.barcelo@gmail.com>	<CAEgOgz41qfxemdK0DX-Euy97jKCwy5EbisH4MbWDSqExHa9M+g@mail.gmail.com>	<20140519184526.00364e81@crunchbang>	<537A363E.309@twiddle.net> <CAEgOgz67q1__z0xdvVmy41iHPdEWOouXNarsaGDEVf17YfgJ6g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: =?UTF-8?B?TWFyYyBNYXLDrQ==?= <marc.mari.barcelo@gmail.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Overall <kvm@vger.kernel.org>,
	=?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	Richard Henderson <rth@twiddle.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:39187 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751322AbaESUfB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 19 May 2014 16:35:01 -0400
In-Reply-To: <CAEgOgz67q1__z0xdvVmy41iHPdEWOouXNarsaGDEVf17YfgJ6g@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


On 19.05.14 22:33, Peter Crosthwaite wrote:
> On Tue, May 20, 2014 at 2:50 AM, Richard Henderson <rth@twiddle.net> =
wrote:
>> On 05/19/2014 09:45 AM, Marc Mar=C3=AD wrote:
>>>>> This STDOUT vs _log() choice is a bit irregular, and I think you =
might
>>>>> be better off abandoning it completely. Richard, Alex, do we real=
ly
>>>>> need to optionally route printfery to log or stderr? (considering=
 _log
>>>>> is NOW stderr by default now, and -D option gives you some flexib=
ility
>>>>> there). Can we have just log and drop STDOUT mode?
>>>>>
>>>>> Regards,
>>>>> Peter
>>> QEMU_DPRINTF outputs to stderr, and, as you say qemu_log does it to=
o.
>>> Should QEMU_DPRINTF be removed and leave only qemu_log?
> Ahh I see now, you want to use the common factored-out code in P1
> which is stderr specific. Perhaps that should use qemu_log. One optio=
n
> would be to create a variant of it in common code that does uses
> qemu_log instead of stderr and use that variant here. That way you ca=
n
> preserve existing behaviour (and maintainer expectations), as much as
> possible.

I think it's safe to assume that all TCG code wants to use qemu_log.


Alex