From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH uq/master] kvm_stat: add option to display non tracepoint
 based stats
Date: Wed, 21 May 2014 12:45:20 +0200
Message-ID: <537C83C0.10304@redhat.com>
References: <20140520183827.GA11998@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: Marcelo Tosatti <mtosatti@redhat.com>,
	kvm-devel <kvm@vger.kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:15251 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752304AbaEUKpZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 21 May 2014 06:45:25 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LAjNCl016315
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Wed, 21 May 2014 06:45:24 -0400
In-Reply-To: <20140520183827.GA11998@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 20/05/2014 20:38, Marcelo Tosatti ha scritto:
>
> The old stats contain information not available in the tracepoints.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 762544b..6ac3b21 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -493,12 +493,21 @@ options.add_option('-f', '--fields',
>                     dest = 'fields',
>                     help = 'fields to display (regex)',
>                     )
> +options.add_option('-o', '--old',
> +                   action = 'store_true',
> +                   default = False,
> +                   dest = 'old',
> +                   help = 'show kvm statistics counters (not tracepoint based)',
> +                   )
>  (options, args) = options.parse_args(sys.argv)
>
> -try:
> -    provider = TracepointProvider()
> -except:
> +if options.old:
>      provider = DebugfsProvider()
> +else:
> +    try:
> +        provider = TracepointProvider()
> +    except:
> +        provider = DebugfsProvider()
>
>  stats = Stats(provider, fields = options.fields)
>
>

Let's instead show information from both providers.  I am sending a patch.

Paolo