From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm_stat: always display non tracepoint based stats Date: Wed, 21 May 2014 14:42:35 +0200 Message-ID: <537C9F3B.9090906@redhat.com> References: <1400669091-28394-1-git-send-email-pbonzini@redhat.com> <20140521122744.GB31090@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62310 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbaEUMmi (ORCPT ); Wed, 21 May 2014 08:42:38 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LCgcU7022923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 May 2014 08:42:38 -0400 In-Reply-To: <20140521122744.GB31090@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Il 21/05/2014 14:27, Marcelo Tosatti ha scritto: > On Wed, May 21, 2014 at 12:44:51PM +0200, Paolo Bonzini wrote: >> The old stats contain information not available in the tracepoints. >> >> Inspired by a patch from Marcelo Tosatti. > > I avoided that because there is overlapping information. > > Now you report kvm_exit count twice, for example. What about doing both, i.e. adding the options and the ability to choose multiple providers? That is, adding --tracepoint and --debugfs options on top of my patch? So if you use --tracepoint and tracing is not available, you get an error unlike the current behavior, and you can also use --tracepoint --debugfs together. Paolo