From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: powerpc/pseries: Use new defines when calling h_set_mode Date: Fri, 30 May 2014 09:44:35 +0200 Message-ID: <538836E3.1060600@suse.de> References: <1401106626-13130-1-git-send-email-paulus@samba.org> <1401106626-13130-4-git-send-email-paulus@samba.org> <5385E620.5090703@suse.de> <1401342462.4116.4.camel@ale.ozlabs.ibm.com> <1401344549.4116.8.camel@ale.ozlabs.ibm.com> <1401349547.4116.19.camel@ale.ozlabs.ibm.com> <5387A63B.4000503@suse.de> <1401400361.14938.16.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Michael Neuling , Paul Mackerras , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" , linuxppc-dev To: Benjamin Herrenschmidt Return-path: In-Reply-To: <1401400361.14938.16.camel@pasglop> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 29.05.14 23:52, Benjamin Herrenschmidt wrote: > On Thu, 2014-05-29 at 23:27 +0200, Alexander Graf wrote: >> On 29.05.14 09:45, Michael Neuling wrote: >>>>> +/* Values for 2nd argument to H_SET_MODE */ >>>>> +#define H_SET_MODE_RESOURCE_SET_CIABR 1 >>>>> +#define H_SET_MODE_RESOURCE_SET_DAWR 2 >>>>> +#define H_SET_MODE_RESOURCE_ADDR_TRANS_MODE 3 >>>>> +#define H_SET_MODE_RESOURCE_LE 4 >>>> Much better, but I think you want to make use of these in non-kvm code too, >>>> no? At least the LE one is definitely already implemented as call :) >>> Sure but that's a different patch.... below. >> Ben, how would you like to handle these 2 patches? If you give me an ack >> I can just put this patch into my kvm queue. Alternatively we could both >> carry a patch that adds the H_SET_MODE header bits only and whoever hits >> Linus' tree first wins ;). > No biggie. Worst case it's a trivial conflict. Well, the way the patches are split right now it won't be a conflict, but a build failure on either side. Alex