From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PULL 33/41] KVM: PPC: Book3S: Move KVM_REG_PPC_WORT to an unused register number Date: Fri, 30 May 2014 17:55:34 +0200 Message-ID: <5388A9F6.5090301@redhat.com> References: <1401453776-55285-1-git-send-email-agraf@suse.de> <1401453776-55285-34-git-send-email-agraf@suse.de> <5388A8DF.9050300@redhat.com> <5388A996.8010606@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com, Paul Mackerras To: Alexander Graf , kvm-ppc@vger.kernel.org Return-path: In-Reply-To: <5388A996.8010606@suse.de> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 30/05/2014 17:53, Alexander Graf ha scritto: >> This is an ABI break, this symbol was added in 3.14. I think I should >> revert this. Can you convince me otherwise? > > There's nothing bad happening with the change. Newer user space won't be > able to read WORT on older kernels, but there were more things broken > that just WORT for POWER8 support there ;). > > And user space build with new headers running on an old kernel won't > find the register, which is OK. Would new userspace with old kernel be able to detect that POWER8 support isn't quite complete? Paolo